snap: Cleanup more environment variable set by launcher script #6969
Conversation
| env.remove("XDG_CONFIG_HOME"); | ||
| env.remove("XDG_CACHE_HOME"); | ||
| env.remove("XDG_DATA_HOME"); |
There was a problem hiding this comment.
I'm not sure this is safe. User or system could set this via systemd and wouldn't the launcher script inherit those paths?
There was a problem hiding this comment.
__
I'm not sure this is safe. User or system could set this via systemd and wouldn't the launcher script inherit those paths?
I think this should be fine. If a user is setting them in their own environment, they will get set when their shell starts. It's just environment variables that are set long enough to get ghostty running, before their shell starts.
There was a problem hiding this comment.
I don't set these variables in my shell init script. I set them in systemd.
There was a problem hiding this comment.
I'm also not sure about this, because the user may not be launching a shell, they can launch any command that could rely on these env vars, no?
There was a problem hiding this comment.
This is the blocker for this PR, any feedback?
kenvandine
force-pushed
the
snap_env_cleanup
branch
from
593a2f5 to
3a85e3c
Compare
Yeah, I already fixed it. |
This unsets a few more environment variables that were set by the launcher script which could potentially effect other apps.